Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 85: Implement analytical solutions in R #90

Merged
merged 15 commits into from
Sep 20, 2024
Merged

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Sep 19, 2024

Description

This PR partially addresses #85 in that it adds analytical solutions in R for the gamma and lognormal with uniform primary censoring.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

This comment was marked as outdated.

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

This comment was marked as outdated.

@SamuelBrand1

This comment was marked as outdated.

This comment was marked as outdated.

@seabbs seabbs force-pushed the analytical-R-solutions branch from 22874e4 to 8dd43a3 Compare September 20, 2024 11:48
@seabbs seabbs marked this pull request as ready for review September 20, 2024 11:48
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (11d0c7f) to head (006d118).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   98.06%   99.76%   +1.69%     
==========================================
  Files          10       10              
  Lines         362      423      +61     
==========================================
+ Hits          355      422      +67     
+ Misses          7        1       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as outdated.

@seabbs seabbs linked an issue Sep 20, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 006d118 is merged into main:

  • ✔️cmdstan_fit_gamma: 7.64s -> 7.66s [-0.43%, +0.88%]
  • 🚀cmdstan_fit_lognormal: 1.65s -> 1.57s [-8.28%, -0.54%]
  • ✔️dprimarycensoreddist_pweibull_expgrowth: 2.35ms -> 2.35ms [-1.34%, +1.72%]
  • ✔️dprimarycensoreddist_weibull: 2.32ms -> 2.3ms [-2.2%, +0.53%]
  • 🚀fitdistdoublecens_gamma_expgrowth: 667ms -> 661ms [-1.35%, -0.55%]
  • 🚀fitdistdoublecens_normal: 553ms -> 549ms [-1.02%, -0.51%]
  • 🚀pprimarycensoreddist_lnorm: 44.7ms -> 1.9ms [-96.87%, -94.64%]
  • ✔️pprimarycensoreddist_plnrom_expgrowth: 47.7ms -> 47.7ms [-1.06%, +1.14%]
    Further explanation regarding interpretation and methodology can be found in the documentation of touchstone.

Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review)

@seabbs seabbs merged commit df08644 into main Sep 20, 2024
13 checks passed
@seabbs seabbs deleted the analytical-R-solutions branch September 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for analytical solutions
2 participants